[HUDI-3330] Remove fixture test tables for multi writer tests #4704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xushiyan
commented
Jan 27, 2022
xushiyan
commented
- Remove fixture test table in zip files
- Revert back to data generation setup with deltastreamer jobs
xushiyan
commented
Jan 27, 2022
Comment on lines
87
to
89
| TypedProperties props = prepareMultiWriterProps(fs(), basePath, propsFilePath); | ||
| props.setProperty("hoodie.write.lock.provider", "org.apache.hudi.client.transaction.lock.InProcessLockProvider"); | ||
| props.setProperty(LockConfiguration.LOCK_ACQUIRE_WAIT_TIMEOUT_MS_PROP_KEY,"3000"); |
Member
Author
There was a problem hiding this comment.
@manojpec you can set configs as needed from here. Maybe the last 2 lines can be moved into prepareMultiWriterProps() as well.
Contributor
There was a problem hiding this comment.
right, quite a repetition of these props in few tests in this file. can be moved to prepareMultiWriterProps()
xushiyan
force-pushed
the
HUDI-3330
branch
2 times, most recently
from
f8cb5b0 to
0fcf479
Compare
Merged
5 tasks
temp CI change disable flaky test Revert "temp CI change" This reverts commit 0fcf479.
Collaborator
liusenhua
pushed a commit
to liusenhua/hudi
that referenced
this pull request
Mar 1, 2022
vingov
pushed a commit
to vingov/hudi
that referenced
this pull request
Apr 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.